Project picker tile sizes #2236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outoftime
requested changes
Apr 20, 2020
There was a problem hiding this comment.
Thanks @Tsamee! I'm not sure that setting the height of the element relative to the viewport is the right approach here—the two don't seem fundamentally related. A couple thoughts:
- You mentioned concerns about breaking function purity when setting a default title, but if that logic were done at render time (e.g. in a selector or the component itself) I don't think there would be any purity problem? Definitely agree that setting a default title in the store is unappealing
- I also don't mind a style fix in general, but maybe you could set a
min-heighton the element that contains the project title, inem?
|
Thanks! Will play with both of those and revise. |
|
Maybe an even cuter solution: Add an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2102
Attempted both of the fixes suggested in the issue, but in the end I just set project-preview height relative to the viewport. Rationale was:
Ran this on a few different screen sizes to make sure the modal is still readable, but I might be wrong there.